Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ws): fix some panics in websocket impls #226

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

zitsen
Copy link
Collaborator

@zitsen zitsen commented Aug 8, 2023

Close TS-3796

@codecov-commenter
Copy link

Codecov Report

Merging #226 (142a9e9) into main (d0fe19c) will decrease coverage by 0.26%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
- Coverage   61.59%   61.34%   -0.26%     
==========================================
  Files         101      101              
  Lines       23340    23354      +14     
==========================================
- Hits        14377    14327      -50     
- Misses       8963     9027      +64     
Files Changed Coverage Δ
taos-ws/src/stmt/mod.rs 80.48% <ø> (ø)
taos-ws/src/query/asyn.rs 72.63% <92.30%> (+0.42%) ⬆️
taos-ws/src/consumer/mod.rs 77.27% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@AdamEECS AdamEECS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zitsen zitsen merged commit 7ed042d into main Aug 9, 2023
@zitsen zitsen deleted the fix/TS-3796-ws-stmt-panic branch August 9, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants