[main] Mass-apply clang-format 20.1.8 (fixes #387) - #393
Conversation
ColinH
left a comment
ColinH
left a comment
There was a problem hiding this comment.
Most changes are fine, but some are not what I want the code to look like and should be removed, of which I flagged a few examples.
| { | ||
| const std::vector< example::my_token > v{ | ||
| { example::my_type::beta, "first" }, | ||
| { example::my_type::beta, "first" }, |
There was a problem hiding this comment.
This is strange and not right, same in token_input_2.cpp.
There was a problem hiding this comment.
@ColinH that's actually feature "vertical alignment" at work:
It can be disabled via the config file. It it not a bug, as far as I can tell.
| using eolof_grammar = until< at< sor< eof, eol_rule > > >; | ||
| const data_t* p = previous( pos ); // TODO: Start earlier? | ||
| const std::size_t s = ( std::min )( max, std::size_t( this->end() - p ) ); | ||
| const std::size_t s = (std::min)( max, std::size_t( this->end() - p ) ); |
There was a problem hiding this comment.
This does not fit with the general style.
There was a problem hiding this comment.
@ColinH I have now flipped the option for true in a second commit and re-applied mass-formatting as a third. So you can see the effect in isolation.
| } | ||
| }, v.data ); | ||
| }, | ||
| v.data ); |
There was a problem hiding this comment.
@ColinH it's a actually a vertical alignment feature at work:
It's a matter of finding the right knob and seeing if it's other options feel more natural.
31c59eb to
89c360b
Compare
|
@ColinH I addressed your findings one by one above. What do you think? |
2 participants
Fixes #387
CC @ColinH