perf(DiffScreen): Reduce git commands during hunk staging, 60-75% performance improvement #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxFangX
changed the title
MaxFangX
force-pushed
the
2025-12-03-better-hunk-stage-latency
branch
from
41e404f to
5c3ba16
Compare
After staging/unstaging a hunk, DiffScreen calls Model:fetch() to refresh the view. This runs several git commands that are unnecessary when we know the file state hasn't fundamentally changed: - git rev-parse --show-toplevel (GitFile creation) - git status (conflict check) - git status (file status) Add Model:refresh_hunks() which skips these redundant checks and only fetches what's needed: current lines and updated hunks. This reduces git commands from ~4-6 to ~1-2 per staging operation.
MaxFangX
force-pushed
the
2025-12-03-better-hunk-stage-latency
branch
from
5c3ba16 to
62d8c83
Compare
Contributor
Author
|
Rebased. |
tanvirtin
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #425; if you rebase merge #425 there will be no conflicts for rebase merging this one.
Description
After staging/unstaging a hunk, DiffScreen calls Model:fetch() to refresh the view. This runs several git commands that are unnecessary when we know the file state hasn't fundamentally changed:
Add Model:refresh_hunks() which skips these redundant checks and only fetches what's needed: current lines and updated hunks. This reduces git commands from ~4-6 to ~1-2 per staging operation (60-75% or roughly 3-4x improvement)