Repository navigation
Upstream's new ProviderTurnStartService memory test fails: the fork's InlineShellStore isn't provided #70
Description
Found 2026-10-20. apps/server/src/orchestration-v2/ProviderTurnStartService.memory.test.ts arrived with today's upstream sync (upstream pingdotgg#22117, 4f5ff17). All 5 of its tests fail on main: the fork's ProviderTurnStartService requires the fork's InlineShellStore (78beec8, inline shell runs), and upstream's test layer doesn't provide it.
Fix (modular, #24): the fork's dependency on InlineShellStore inside the upstream service should be optional, through Effect.serviceOption or a small fork hook, so upstream's test layers keep working unchanged. Alternatively, provide it from a fork-owned test harness. Don't edit upstream's test file.
Process gap: the sync ran tests only for files the merge touched, so a newly added upstream test that exercises fork-modified services was never run. The daily sync's checks should also run every test file the sync added or changed under apps/server.
Activity
tannerpolley commentedon Oct 21, 2026
T3 Code status: Done
Issue: #70 Upstream's new ProviderTurnStartService memory test fails: the fork's InlineShellStore isn't provided
Thread: thread:delegated-task:command%3Amcp%3A667e5306-5428-4b55-a9f6-4ae3fcb3609b%3Adelegate-task%3Aissue-70-worker-1
Model: gpt-6.1-sol
Branch: issue-70-upstreams-new-providerturnstartservice
Updated: 2026-10-21T00:48:05.368Z
tannerpolley commentedon Oct 21, 2026
T3 Code closeout: done
Issue: #70 Upstream's new ProviderTurnStartService memory test fails: the fork's InlineShellStore isn't provided
Thread: thread:delegated-task:command%3Amcp%3A667e5306-5428-4b55-a9f6-4ae3fcb3609b%3Adelegate-task%3Aissue-70-worker-1
Model: gpt-6.1-sol
Branch: issue-70-upstreams-new-providerturnstartservice
Completed: 2026-10-21T00:48:04.712Z
Implemented and pushed the fix for #70.
issue-70-upstreams-new-providerturnstartserviceb9f6efde30Closes #70and the requested co-author trailer.ProviderTurnStartServicenow readsInlineShellStorethroughEffect.serviceOptionand removes it from the layer’s required dependencies. When absent, it uses the original provider session directly. When present, it retains the existing inline-shell delivery and error handling.Production wiring in
runtimeLayer.tsis unchanged and still providesInlineShellStore.layer. The existing fork test confirming shell output injection into provider prompts passes. Upstream’s memory test file is unchanged.Validation passed:
ProviderTurnStartServicefiles,InlineShellStore,InlineShellRuns, andInlineShellLaunch.tsc-rs --noEmit: exit 0; advisory suggestions only.git diff --check: passed.Other upstream service constructors with hard fork-only dependencies found:
ProviderTurnControlService→InlineShellStoreProjectService→SidebarLayoutServiceWorktreeMcpService→ThreadWorkspaceServiceThose dependencies remain unchanged and have explicit test-layer provisions. The scan also found fork-only lookups in environment and preview MCP handlers, outside service constructors.
No servers, live userdata, repo-wide checks, PR creation, or merge were performed. Review and integration remain with the parent task.