This repository was archived by the owner on Jul 8, 2022. It is now read-only.
Set the ZMQ Receive Buffer High Water Mark only if it changes (#444) #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bourtemb Do you know the upstream commit ID where the bug is fixed? |
|
Matej (@mkomel) was talking about the following commit: zeromq/libzmq@edc770d in #444 |
|
@tango-tickets-migrator Thx. |
Ingvord
reviewed
May 4, 2018
There was a problem hiding this comment.
I would extract the whole snippet to a method and move comment to method's documentation:
/**
* Set the ZMQ Receive Buffer High Water Mark only if it changes
* This is to reduce the impact of a bug present in ZMQ 4.2.0 and ZMQ 4.2.1
* which leads to a bad lwm and hwm calculation when ZMQ_RCVHWM is set after
* the bind of the socket. See cppTango#444 for more details
*
* @param ...
*
*/
void set_sockect_hwm(size_t hwm, socket* socket /*etc*/)When extracting method please prefer passing arguments rather than class fields (whenever possible) - this simplifies further refactorings
…controls#444) This is to reduce the impact of a bug present in ZMQ 4.2.0 and ZMQ 4.2.1 which led to a bad lwm and hwm calculation when ZMQ_RCVHWM was set after the bind of the socket. See cppTango#444 for more details
Ingvord
approved these changes
May 4, 2018
bourtemb
added a commit
to bourtemb/cppTango
that referenced
this pull request
Jul 17, 2018
…controls#444) (tango-controls#445) This is to reduce the impact of a bug present in ZMQ 4.2.0 and ZMQ 4.2.1 which led to a bad lwm and hwm calculation when ZMQ_RCVHWM was set after the bind of the socket. See cppTango#444 for more details
85 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to reduce the impact of a bug present in ZMQ 4.2.0 and ZMQ 4.2.1 which led to a bad lwm and hwm calculation when ZMQ_RCVHWM was set after the bind of the socket. See #444 for more details