Open
Conversation
1 similar comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
nock just published its new version 8.2.0.
This version is covered by your current version range and after updating it in your project the build went from success to failure.
As nock is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 47 commits .
540720d8.2.00712456Add changelog to the dev dependencies2ecf1ecIgnore browserify-bundle.js28acae0Update browserify-bundle.jsd5962f2Merge pull request #723 from pimterry/optional-mocks142c818Include all review markup changes in browserify-bundlee72ab0aAdd .activeMocks() to recreate previous .pendingMocks() behaviour475d605Add times+optional and persist+optional tests475c7a5Document assumption in pendingMocks()143e42eClarify optional mock behaviour a little in README5af77f0Merge pull request #721 from pimterry/removeInterceptor-from-pendingbe02f3eMerge pull request #722 from Ginden/no-garbage-in-npm768e9d4Merge pull request #668 from abdulito/master0768403Merge pull request #725 from node-nock/greenkeeper-async-2.1.14a266e8Merge pull request #719 from ltegman/fix/body-spec-regex-in-arrayThere are 47 commits in total. See the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? ⚡
greenkeeper upgrade