Open
Conversation
1 similar comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
nock just published its new version 9.0.4.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of nock.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 98 commits .
8f20a6d9.0.4: Fix bug where only single set-cookie header would be returned3bae02dMerge pull request #820 from node-nock/bug-818-multiple-set-cookie189894eMerge pull request #813 from node-nock/greenkeeper-tap-10.0.020dceebBug #818 Assert mutiple set-cookie headers are included in object6b54bdbBug #818 Send back multiple headers if multiple presentdc4380f9.0.3: Change error message for unmatched requests44a8eb6Merge pull request #819 from node-nock/chore-add-ian-contrib93401b2Add Ian WS to contrib2e64126Merge pull request #597 from ianwsperber/feature-better-unmatched-request-errorc4c5e0fchore(package): update tap to version 10.0.0634fdffMerge pull request #799 from node-nock/greenkeeper-tap-9.0.3f6d3e76Merge pull request #797 from Thebigbignooby/patch-1ca9f1ccUse pretty JSON and no longer stringify body4e0f62dOnly include body in stringified request for non-GET requests794821dUpdate intercept tests for new stringified formatThere are 98 commits in total. See the full diff.
Screencast
Try it today. Free for private repositories during beta.