Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : Accepting a RefreshProposal should clear all pending unsigned RefreshProposals #725

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

1xstj
Copy link
Contributor

@1xstj 1xstj commented Oct 24, 2023

Summary of changes
Changes introduced in this pull request:

@1xstj 1xstj requested a review from shekohex October 24, 2023 17:58
@1xstj 1xstj marked this pull request as ready for review October 24, 2023 17:58
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d5512ea) 18.79% compared to head (4cec5cf) 18.47%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
- Coverage   18.79%   18.47%   -0.31%     
==========================================
  Files          80       80              
  Lines        5958     5969      +11     
==========================================
- Hits         1119     1102      -17     
- Misses       4839     4867      +28     
Files Coverage Δ
pallets/dkg-proposal-handler/src/lib.rs 48.82% <ø> (-7.08%) ⬇️
pallets/dkg-proposal-handler/src/impls.rs 75.41% <90.91%> (-0.59%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG just need to fix CI

@drewstone drewstone merged commit e20c92d into master Oct 24, 2023
7 checks passed
@drewstone drewstone deleted the fix-handle-signed-refresh-proposal branch October 24, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Accepting a RefreshProposal should clear all pending unsigned RefreshProposals
3 participants