Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increase delay before keygen is retried #718

Merged
merged 1 commit into from
Oct 6, 2023
Merged

fix: increase delay before keygen is retried #718

merged 1 commit into from
Oct 6, 2023

Conversation

1xstj
Copy link
Contributor

@1xstj 1xstj commented Oct 6, 2023

Summary of changes
Changes introduced in this pull request:

  • We have a hook that checks every interval after SessionPeriod has passed if we have a new key posted on chain, if not we retrigger the worker to generate new key, this PR increases this interval from 10 blocks to 20 blocks. In the testnet we see cases where keygen is posted succesfully after 10 blocks but this check retriggers the whole process.

@1xstj 1xstj requested a review from shekohex October 6, 2023 18:42
@drewstone drewstone merged commit 91e1af6 into master Oct 6, 2023
6 of 7 checks passed
@drewstone drewstone deleted the increase-retry-delay branch October 6, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewstone drewstone drewstone approved these changes

@tbraun96 tbraun96 Awaiting requested review from tbraun96 tbraun96 is a code owner

@shekohex shekohex Awaiting requested review from shekohex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1xstj @drewstone