Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] improvements to proposal handling #690

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Conversation

1xstj
Copy link
Contributor

@1xstj 1xstj commented Jul 20, 2023

Summary of changes
Changes introduced in this pull request:

  • Split batch creation and proposal expiry to seperate jobs, batch creation is first priority and expiration will run only with leftover weights
  • Add ext to force_remove_proposal from queue
  • Modify ProposalBatchRemoved and ProposalBatchExpired events
  • Unify all dkg-gadget constants to constants.rs file
  • Reduce signing_manager MAX_RUNNING_TASKS to 1

@1xstj 1xstj added the In testnet Being tested in testnet label Jul 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Patch coverage: 55.18% and project coverage change: +0.20 🎉

Comparison is base (1bc7865) 15.80% compared to head (04f7e8a) 16.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #690      +/-   ##
==========================================
+ Coverage   15.80%   16.00%   +0.20%     
==========================================
  Files          76       76              
  Lines        5514     5552      +38     
==========================================
+ Hits          871      888      +17     
- Misses       4643     4664      +21     
Impacted Files Coverage Δ
dkg-gadget/src/gossip_engine/network.rs 0.00% <ø> (ø)
dkg-gadget/src/keygen_manager/mod.rs 0.00% <ø> (ø)
dkg-gadget/src/lib.rs 0.00% <ø> (ø)
dkg-gadget/src/signing_manager/mod.rs 0.00% <ø> (ø)
dkg-gadget/src/worker.rs 0.00% <ø> (ø)
pallets/dkg-proposal-handler/src/lib.rs 46.24% <16.67%> (-9.20%) ⬇️
pallets/dkg-proposal-handler/src/functions.rs 30.13% <65.22%> (+13.46%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@1xstj 1xstj marked this pull request as ready for review July 20, 2023 10:55
@1xstj 1xstj self-assigned this Jul 20, 2023
Copy link
Contributor

@shekohex shekohex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@1xstj 1xstj merged commit e5dcecb into master Jul 20, 2023
6 checks passed
@1xstj 1xstj deleted the test-throttled-signing-manager branch July 20, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks API In testnet Being tested in testnet
Projects
Status: Completed ✅
Development

Successfully merging this pull request may close these issues.

3 participants