IOS-7818 Bump deployment target up to 15 #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tureck1y
commented
Sep 6, 2024
•
tureck1y
commented
- Поднял мин таргет до 15, как в приложении
- Удалил available и неиспользуемый более код
- Прошелся по ворнингам
- Выполнил bundle update в корне и в Example
- Обновил проект до рекомендуемых настроек
- Обновил подспек и package
- Немного потестил по ключевым местам, ничего не отвалилось, анимации на месте
fedorov-d
previously approved these changes
Sep 6, 2024
fedorov-d
approved these changes
Sep 10, 2024
Andoran90
approved these changes
Sep 10, 2024
Comment on lines
+15
to
+16
| // let seed = "gravity machine north sort system female filter attitude volume fold club stay feature office ecology stable narrow fog" | ||
| // let passphrase = "TREZOR" |
There was a problem hiding this comment.
Оставил, чтобы понять откуда тестовые данные взялись
m3g0byt3
approved these changes
Sep 10, 2024
Comment on lines
+45
to
+49
| let scene = UIApplication.shared.connectedScenes | ||
| .filter { $0.activationState == .foregroundActive } | ||
| .first as? UIWindowScene | ||
|
|
||
| return scene?.keyWindow?.topmostViewController |
There was a problem hiding this comment.
Надо попросить QA потестить это место, потому что этот код не равнозначный
Ранее было просто keyWindow, а теперь keyWindow в foreground
В основном приложении я натыкался на кейс, когда это стреляло и window не находился при каких-то сценариях перехода bg->fg и обратно
There was a problem hiding this comment.
А не помнишь что за кейс? В прямых кейсах проблем не обнаружил
There was a problem hiding this comment.
Нет, не помню увы
Это было очень давно
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.