Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOS-4025 Refactor preflight filtering #329

Merged
merged 14 commits into from
Nov 28, 2023
Merged

IOS-4025 Refactor preflight filtering #329

merged 14 commits into from
Nov 28, 2023

Conversation

tureck1y
Copy link
Collaborator

@tureck1y tureck1y commented Nov 9, 2023 •
edited
Loading

Задача:

  • научиться фильтровать комплекты карт так же как и сами карты - без остановки сессии.

Вводные:

  • сохранить текущую логику сессии, завязанную на cardId
  • не хочется сильно менять и усложнять интерфейс
  • в будущем в прошивке появится свой идентификатор, который позволит фильтровать забэкапленные комплекты без дополнительных вычислений

Фильтр прокидываем снаружи. Когда появится новый механизм, сделаем cardKitId и будем юзать его, вместо кастомного

@tureck1y tureck1y marked this pull request as ready for review November 10, 2023 20:44
@tureck1y tureck1y requested a review from a team as a code owner November 10, 2023 20:44
megakoko
megakoko previously approved these changes Nov 13, 2023
View reviewed changes
Andoran90
Andoran90 previously approved these changes Nov 13, 2023
View reviewed changes
TangemSdk/TangemSdk/Operations/PreflightReadFilter/PublicKeyPreflightReadFilter.swift Outdated Show resolved Hide resolved
TangemSdk/TangemSdk/TangemSdk.swift Outdated Show resolved Hide resolved
TangemSdk/TangemSdk/TangemSdk.swift Outdated Show resolved Hide resolved
@tureck1y tureck1y dismissed stale reviews from Andoran90 and megakoko via 2571968 November 21, 2023 19:12
@tureck1y
Copy link
Collaborator Author

tureck1y commented Nov 22, 2023 •
edited
Loading

Отрефакторил, чтобы и твины работали, теперь фильтры прокидываются снаружи)

@tureck1y tureck1y mentioned this pull request Nov 22, 2023
Merged
megakoko
megakoko previously approved these changes Nov 24, 2023
View reviewed changes
@tureck1y tureck1y merged commit 4399166 into develop Nov 28, 2023
3 checks passed
@tureck1y tureck1y deleted the IOS-4025_refactor_prefligh_filtering branch November 28, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andoran90 Andoran90 Andoran90 approved these changes

@megakoko megakoko Awaiting requested review from megakoko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tureck1y @megakoko @Andoran90