Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOS-3934 Improved example application layout on small phones #310

Merged
merged 3 commits into from
Jul 26, 2023
Merged

IOS-3934 Improved example application layout on small phones #310

merged 3 commits into from
Jul 26, 2023

Conversation

megakoko
Copy link
Contributor

@megakoko megakoko commented Jul 19, 2023 •
edited
Loading

До и после:

IMG_0431

IMG_0430

@megakoko megakoko requested review from a team and Andoran90 and removed request for a team July 19, 2023 14:07
@megakoko megakoko marked this pull request as ready for review July 19, 2023 14:09
@megakoko megakoko requested a review from tureck1y as a code owner July 19, 2023 14:09
Andoran90
Andoran90 previously approved these changes Jul 20, 2023
View reviewed changes
@tureck1y
Copy link
Collaborator

Json editor накладывается на барабан и перестает быть кликабельным

нормально
IMG_0070

не нажимается
IMG_0071

tureck1y
tureck1y requested changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@tureck1y tureck1y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

мне кажется можно просто область верхнюю уменьшить да и все, есть проблемы и на больших девайсах

@megakoko
IOS-3934 Merge remote-tracking branch 'origin/develop' into IOS-3934-…
d6da4af 
…card-sdk-example-app-unusable-layout-on-small-phones
@megakoko
Copy link
Contributor Author

Спасибо, поправил, Андрей на восьмерке посмотрел

@tureck1y
Copy link
Collaborator

проверил, нормально теперь

@megakoko megakoko enabled auto-merge July 26, 2023 14:41
@megakoko megakoko merged commit 4618a20 into develop Jul 26, 2023
1 check passed
@megakoko megakoko deleted the IOS-3934-card-sdk-example-app-unusable-layout-on-small-phones branch July 26, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andoran90 Andoran90 Andoran90 approved these changes

@tureck1y tureck1y tureck1y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@megakoko @tureck1y @Andoran90