IOS-2914: Add Secp256k1UnmarshalSignature as return value in Secp256k1Signature
#309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Balashov152
requested review from
a team and
m3g0byt3
and removed request for
a team
Balashov152
force-pushed
the
IOS-2914-Add-Secp256k1UnmarshalSignature
branch
from
89a8174
to
53d8dfa
Compare
tureck1y
reviewed
Jul 11, 2023
| import Foundation | ||
|
|
||
| @available(iOS 13.0, *) | ||
| public struct Secp256k1UnmarshalSignature { |
There was a problem hiding this comment.
- Secp256k1ExtendedSignature или вложенный тип Secp256k1Signature.Extended
- Давай везде сделаем правильный порядок переменных: r,s,v (в конструкторе, в классе, в утилите Secp256k1Utils)
- sum -> data
There was a problem hiding this comment.
тесты еще надо поправить
IOS-2914 Add `Secp256k1UnmarshalSignature` as return value in `Secp256k1Signature` Update Secp256k1UnmarshalSignature.swift
Balashov152
force-pushed
the
IOS-2914-Add-Secp256k1UnmarshalSignature
branch
from
53d8dfa
to
bdaaa5b
Compare
tureck1y
approved these changes
Jul 11, 2023
m3g0byt3
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOS-2914