IOS-3108 Do not release a remembered tag until the operation completion #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tureck1y
requested review from
a team,
skibinalexander and
Andoran90
and removed request for
a team
skibinalexander
previously approved these changes
Feb 28, 2023
Andoran90
reviewed
Feb 28, 2023
Andoran90
approved these changes
Mar 1, 2023
skibinalexander
approved these changes
Mar 1, 2023
lazutkin-andrey
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Мы не отслеживали ситуацию с прислонением неправильной карты после введения кода (или восстановления кода). Прилетала ошибка инвалид парамс. Я слегка подправил механизм отслеживания текущего тэга, который использовался для проверки карты при реконнектах. Теперь тэг запоминается и держится до тех пор, пока текущая команда не выполнится успешно или не зафейлится окончательно. Если требуется ввести код, то тэг не сбрасывается.