IOS-2474 Shrinking User Code change header text #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tureck1y
reviewed
Dec 28, 2022
| @@ -26,6 +26,8 @@ struct UserCodeHeaderView: View { | |||
|
|
|||
| Text(title) | |||
| .font(Font.system(size: 34).bold()) | |||
| .minimumScaleFactor(0.7) | |||
There was a problem hiding this comment.
это очень глючный модификатор, надо без него
There was a problem hiding this comment.
Через fixedSize не хочется, места мало остается если оставлять текст в две строки. На семерке скорее всего поедет лейаут.
There was a problem hiding this comment.
fixedSize тут не подойдет. Динамически вообще ничего сделать. Обсудите с Яном пожалуйста, может он предложит слегка шрифт уменьшить или может текстовку заголовка можно поменять на более короткую.
There was a problem hiding this comment.
Договорились на уменьшение шрифта
Проверил в симуляторе на 7 и на 7 с зумом, выглядело нормально на 28. Сделал 24 для подстраховки.
tureck1y
approved these changes
Dec 28, 2022
tureck1y
deleted the
IOS-2474-change-pin-the-header-does-not-fit-in-the-line
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Была такая штука.
Стало так. На минике не сильно скукоживается.
