IOS-2592 wording conflicts card #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
common_warning -> dialog_attestation_completed_with_warnings_title pin_change_code_format -> pin_set_code_format enter_user_code_button_title_forgot -> reset_codes_btn_forgot_your_code error_not_supported_firmware_version -> error_old_firmware attestation_failed_card -> dialog_attestation_did_failed_message attestation_online_failed_title -> dialog_attestation_completed_offline_title attestation_online_failed_body -> dialog_attestation_completed_offline_message
…wording-conflicts-card
…pleted_with_warnings_message
tureck1y
reviewed
Dec 8, 2022
| @@ -7,17 +7,17 @@ | |||
| "common_continue" = "Fortsetzen"; | |||
| "common_success" = "Erfolg"; | |||
| "common_error" = "Fehler"; | |||
| "common_warning" = "Warning"; | |||
| "dialog_attestation_completed_with_warnings_title" = "Warning"; | |||
There was a problem hiding this comment.
Этот ключ в одном месте используется, поэтому не заморачивался и взял из андроида
| "attestation_online_failed_title" = "Online attestation failed"; | ||
| "attestation_online_failed_body" = "We cannot finish card's online attestation at this time. You can continue at your own risk and try again later, retry now or cancel the operation"; | ||
| "attestation_warning_attest_wallets" = "Too many runs of Attest Wallet or Sign looks suspicious."; | ||
| "dialog_attestation_did_failed_message" = "This card may be production sample or counterfeit. You can continue at your own risk"; |
There was a problem hiding this comment.
зря затащили андроидовские слова в ключах к нам, лучше бы конечно более универсальные ключи использовать, если не сложно, лучше сразу поменять
There was a problem hiding this comment.
Переименовал обратно
…line_failed_title
…online_failed_body
…ation_warning_attest_wallets
tureck1y
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
первый подход к синхронизации