IOS-2393 Add reset-pin service localisation #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tureck1y
reviewed
Oct 25, 2022
TangemSdk/TangemSdk/Common/Localization/de.lproj/Localizable.strings
Outdated
Show resolved
Hide resolved
|
кстати эта не бэкап сервис, а сервис сброса кода) |
megakoko
changed the title
Голова уже в тыкву превратилась ): |
tureck1y
previously approved these changes
Oct 27, 2022
| @@ -53,9 +53,13 @@ | |||
| "attestation_online_failed_title" = "Online attestation failed"; | |||
| "attestation_online_failed_body" = "We cannot finish card's online attestation at this time. You can continue at your own risk and try again later, retry now or cancel the operation"; | |||
| "attestation_warning_attest_wallets" = "Too many runs of Attest Wallet or Sign looks suspicious."; | |||
| "reset_codes_scan_first_card" = "Scan the card on which you want to reset the pin"; | |||
| @@ -53,9 +53,13 @@ | |||
| "attestation_online_failed_title" = "Online attestation failed"; | |||
| "attestation_online_failed_body" = "We cannot finish card's online attestation at this time. You can continue at your own risk and try again later, retry now or cancel the operation"; | |||
| "attestation_warning_attest_wallets" = "Too many runs of Attest Wallet or Sign looks suspicious."; | |||
| "reset_codes_scan_first_card" = "Scan the card on which you want to reset the pin"; | |||
| @@ -53,9 +53,13 @@ | |||
| "attestation_online_failed_title" = "Online attestation failed"; | |||
| "attestation_online_failed_body" = "We cannot finish card's online attestation at this time. You can continue at your own risk and try again later, retry now or cancel the operation"; | |||
| "attestation_warning_attest_wallets" = "Too many runs of Attest Wallet or Sign looks suspicious."; | |||
| "reset_codes_scan_first_card" = "Scan the card on which you want to reset the pin"; | |||
There was a problem hiding this comment.
Suggested change
| "reset_codes_scan_first_card" = "Scan the card on which you want to reset the pin"; | |
| "reset_codes_scan_first_card" = "Scan the card on which you want to reset the access code"; |
| @@ -53,9 +53,13 @@ | |||
| "attestation_online_failed_title" = "Online attestation failed"; | |||
| "attestation_online_failed_body" = "We cannot finish card's online attestation at this time. You can continue at your own risk and try again later, retry now or cancel the operation"; | |||
| "attestation_warning_attest_wallets" = "Too many runs of Attest Wallet or Sign looks suspicious."; | |||
| "reset_codes_scan_first_card" = "Scan the card on which you want to reset the pin"; | |||
There was a problem hiding this comment.
Suggested change
| "reset_codes_scan_first_card" = "Scan the card on which you want to reset the pin"; | |
| "reset_codes_scan_first_card" = "Scan the card on which you want to reset the access code"; |
| @@ -53,9 +53,13 @@ | |||
| "attestation_online_failed_title" = "Online attestation failed"; | |||
| "attestation_online_failed_body" = "We cannot finish card's online attestation at this time. You can continue at your own risk and try again later, retry now or cancel the operation"; | |||
| "attestation_warning_attest_wallets" = "Too many runs of Attest Wallet or Sign looks suspicious."; | |||
| "reset_codes_scan_first_card" = "Scan the card on which you want to reset the pin"; | |||
There was a problem hiding this comment.
Suggested change
| "reset_codes_scan_first_card" = "Scan the card on which you want to reset the pin"; | |
| "reset_codes_scan_first_card" = "Scan the card on which you want to reset the access code"; |
| @@ -53,9 +53,13 @@ | |||
| "attestation_online_failed_title" = "Онлайн-аттестация не удалась"; | |||
| "attestation_online_failed_body" = "В настоящее время мы не можем завершить онлайн-аттестацию карты. Вы можете продолжить на свой страх и риск и повторить попытку позже, повторить сейчас или отменить операцию."; | |||
| "attestation_warning_attest_wallets" = "Слишком большое количество вызовов Attest Wallet или Sign выглядит подозрительно."; | |||
| "reset_codes_scan_first_card" = "Отсканируйте карту, на которой вы хотите сбросить пин-код"; | |||
There was a problem hiding this comment.
Suggested change
| "reset_codes_scan_first_card" = "Отсканируйте карту, на которой вы хотите сбросить пин-код"; | |
| "reset_codes_scan_first_card" = "Отсканируйте карту, на которой вы хотите сбросить код доступа"; |
|
Может лучше тогда подставлять название кода? Сервис прекрасно работает и с пасскодами |
Не получится, проблема в том, что "Access Code" / "Passcode" локализованы на пять языков, а эти текстовки только на два. Можно сделать нейтрально:
|
| @@ -53,9 +53,13 @@ | |||
| "attestation_online_failed_title" = "Online attestation failed"; | |||
| "attestation_online_failed_body" = "We cannot finish card's online attestation at this time. You can continue at your own risk and try again later, retry now or cancel the operation"; | |||
| "attestation_warning_attest_wallets" = "Too many runs of Attest Wallet or Sign looks suspicious."; | |||
| "reset_codes_scan_first_card" = "Scan the card on which you want to reset the pin"; | |||
There was a problem hiding this comment.
Suggested change
| "reset_codes_scan_first_card" = "Scan the card on which you want to reset the pin"; | |
| "reset_codes_scan_first_card" = "Scan the card on which you want to reset the access code"; |
Локализация уже устарела, половина сдк не переведена. А все экраны, связанные с кодами, через подстановку и работают. |
tureck1y
approved these changes
Oct 31, 2022
lazutkin-andrey
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Текстовки для сервиса сброса кодов взял из андроида. "Scan the confirmation card" теперь поменялось на "Scan another linked card".
В табличку все добавил.