IOS-5193 Refactor scanning #3134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tureck1y
commented
Apr 12, 2024
tureck1y
commented
Apr 12, 2024
| @@ -12,7 +12,7 @@ import TangemSdk | |||
| struct OnboardingInput { // TODO: Split to coordinator options and input | |||
| let backupService: BackupService | |||
| let primaryCardId: String | |||
| let cardInitializer: CardInitializable? | |||
| let cardInitializer: CardInitializer? | |||
There was a problem hiding this comment.
Тут и далее переименование для соответствия сканнеру. Придумать красивое название для соответствиям остальным интеракторам не получилось
tureck1y
commented
Apr 12, 2024
| @@ -83,7 +81,26 @@ class CommonUserWalletRepository: UserWalletRepository { | |||
| } | |||
|
|
|||
| private func scanPublisher() -> AnyPublisher<UserWalletRepositoryResult?, Never> { | |||
| scanInternal() | |||
| var config = TangemSdkConfigFactory().makeDefaultConfig() | |||
There was a problem hiding this comment.
Временный перенос, в задаче с Моками сканер вообще вынесу отсюда https://tangem.atlassian.net/browse/IOS-6570
tureck1y
commented
Apr 12, 2024
| import Foundation | ||
| import TangemSdk | ||
|
|
||
| protocol CardInitializer { |
There was a problem hiding this comment.
переименовал и вынес отдельно
tureck1y
commented
Apr 12, 2024
| @@ -76,6 +65,9 @@ extension CardInitializer: CardInitializable { | |||
| case .failure(let error): | |||
| completion(.failure(error)) | |||
| } | |||
|
|
|||
| withExtendedLifetime(task) {} | |||
There was a problem hiding this comment.
Слегка обновил на актуальный подход
tureck1y
commented
Apr 12, 2024
Comment on lines
+19
to
+21
| func scanCard(completion: @escaping (Result<AppScanTaskResponse, TangemSdkError>) -> Void) | ||
| func scanCardPublisher() -> AnyPublisher<AppScanTaskResponse, TangemSdkError> | ||
| } |
There was a problem hiding this comment.
Пока два метода, возможно в задаче с Моками оставлю один
tureck1y
commented
Apr 12, 2024
| performDerivations: parameters.performDerivations | ||
| ) | ||
|
|
||
| let didBecomeActivePublisher = NotificationCenter.didBecomeActivePublisher |
There was a problem hiding this comment.
Для сканнера тоже актуально, чтобы анимации норм играли
tureck1y
commented
Apr 12, 2024
| @@ -43,12 +43,17 @@ struct AppScanTaskResponse { | |||
| final class AppScanTask: CardSessionRunnable { | |||
| let shouldAskForAccessCode: Bool | |||
|
|
|||
| private let performDerivations: Bool | |||
There was a problem hiding this comment.
Для более быстрого скана в детеилс
Andoran90
previously approved these changes
Apr 15, 2024
|
обновил тэг |
Andoran90
approved these changes
Apr 16, 2024
Balashov152
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Рефакторинг последней части по работе с картами - сканнера.