[Fix] Always render all slots #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List height is determined by item height and visible items number (`remain` prop) and this works flawless as long as this number is {Integer}. But... when `remain` prop is set dynamically to {Float} (for ex.: list fills all available vertical space in UI), last item in scrollable list won't be rendered (for ex.: `delta.end' can equal `58.6` for `59` items, so only 58 slots are rendered).
This solution fixes the problem.
|
Thanks! I have published v1.2.8 for this fix. |
|
No problem, your component saved me a lot of work so I should be thanking
you ;)
Have a nice day,
Przemysław
czw., 16 sie 2018, 13:51 użytkownik tangbc <notifications@github.com>
napisał:
… Thanks!
I have published v1.2.8 for this fix.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#63 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AkkiP3ymF6AG9CBJS_gz5pnN20vvdgbBks5uRVzAgaJpZM4V_qZp>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List height is determined by item height and visible items number (
remainprop) and this works flawless as long as this number is {Integer}. But... whenremainprop is set dynamically to {Float} (for ex.: list fills all available vertical space in UI), last item in scrollable list won't be rendered (for ex.:delta.endcan equal58.6for 59 items, so only 58 slots are rendered).This solution fixes the problem.