Dev dynamic remain #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank for your contribution, but… your pr has a big change compared to the original. I think it's better keeping my original demo entry (config), I think every update from others should't remove origin code if it's not wrong. |
|
Hello, sorry for that, I had to do this changes really quickly ^^ Thank's for this package you've done ;) |
|
Sorry not free these days, I just checkout the code, I found there is an large file: bigata.json about 42.5M !!😱 I think it's terrible putting such a big test data into repo... At last, let me consider the feature "dynamic remain" , I think that could be done by other better ways ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADD dynamic on remain and slots changes to avoid scrolling issues when data changes.
Sory for reset the dev mode...