Title the catch-all release-notes category for what it holds - #3029
Merged
Conversation
Most weeks release nothing but patches, so "Everything Else" ends up the only heading in the generated notes — and a heading that defines itself by contrast reads as a mistake when there is nothing to contrast it with. "Fixes & Maintenance" reads alone and reads as the third of three. It is also the more honest name: under the label convention every PR that falls through to the catch-all is a patch, so this was never a junk drawer for uncategorised work. Showing the heading only when the other two are populated is not expressible here. GitHub evaluates this file identically every release, so a conditional heading would mean generating the notes by hand rather than letting GitHub write them. Dropping the catch-all instead is worse: without `*` GitHub omits the unmatched pull requests from the notes entirely, which on a patch-only week is all of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most weeks release nothing but patches, so "Everything Else" ends up the only heading in the generated notes — and a heading that defines itself by contrast reads as a mistake when there is nothing to contrast it with.
"Fixes & Maintenance" reads alone and reads as the third of three. It is also the more honest name: under the label convention every PR that falls through to the catch-all is a patch, so this was never a junk drawer for uncategorised work.
Showing the heading only when the other two are populated is not expressible here. GitHub evaluates this file identically every release, so a conditional heading would mean generating the notes by hand rather than letting GitHub write them. Dropping the catch-all instead is worse: without
*GitHub omits the unmatched pull requests from the notes entirely, which on a patch-only week is all of them.Cosmetic and forward-only — already-published releases keep the heading they were generated with.