Read the default branch in the release guard - #3028
Merged
Merged
Conversation
The guard named `master` outright. That is correct here and will stay correct, so this is not a fix — it is alignment with the shape the fleet documents, now that tanem/release-action's README and the decision spec both read the default branch rather than naming one. The reading form exists because a literal is a trap in anything copied: name a branch the repo does not have and every release skips, silently and forever. tanem/release-action itself is on main, and GitHub creates new repos on main, while every existing fleet repo is on master. Keeping all the fleet's release workflows on one form means a future reader diffing them against the spec finds no drift to explain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guard named
masteroutright. That is correct here and will stay correct, so this is not a fix — it is alignment with the shape the fleet documents, now thattanem/release-action's README and §3.1 of the decision spec both read the default branch rather than naming one.The reading form exists because a literal is a trap in anything meant to be copied: name a branch the repo doesn't have and every release skips, silently and forever.
tanem/release-actionitself is onmain, and GitHub creates new repos onmain, while every existing fleet repo is onmaster. The generator will stamp the reading form for the same reason.Keeping every fleet release workflow on one form means a future reader diffing them against the spec finds no drift to explain.