Skip to content

Conversation

Plaqueoff
Copy link
Collaborator

Cherry picked the diagnostics changes from rolling.

Tested on simulation!

@Plaqueoff Plaqueoff requested a review from tanelikor October 12, 2023 07:53
Copy link
Owner

@tanelikor tanelikor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with the older lifecycle code but LGTM on the changes. Found one typo that you can fix if you want to, otherwise this seems good to go.

@tanelikor tanelikor merged commit 7d9180d into cherry-pick-collision-monitor-limit-to-humble Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants