Rework serial port routines #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * Fixed usage of deprecated get_figure_handle() on 6.1.1 * Turned on compiler warnings for gateway files * Made port name/number a string, not an integer * On Windows port may be defined by its name or number * All port numbers are accessible on Windows: COM1..COM255 * On Linux port name should be a full device path e.g. '/dev/ttyUSB5' * More error checking and handling. * Better error messages for syscalls errors * No more memory leaks due to unused 'OK' variables * No more static storage for port handlers: native handler (or file descriptor on Linux) is returned to Scilab and received from it; Number of boards used is no more limited * Disabled flow control configuration on Windows
msalau
force-pushed
the
serial-port-handling-rework
branch
from
e80f738
to
ad5466b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
get_figure_handle()on 6.1.1COM1..COM255/dev/ttyUSB5OKvariablesdescriptor on Linux) is returned to Scilab and received from it;
Number of boards used is no more limited
Tested with Scilab 6.1.1 on Windows 10 64bit (MSVC v142 Community Edition) and Linux64 (GCC v11.2).
Symlinks were tested and work perfectly fine on Linux.
This change was developed fully independently from #1 and they overlap a bit, but this change has much greater level of rework for the sci_gateway code.