fix error scenario if user enters lowercase letters in passport number #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tananaev
reviewed
Sep 12, 2024
| @@ -121,7 +121,7 @@ abstract class MainActivity : AppCompatActivity() { | |||
| override fun onTextChanged(s: CharSequence, start: Int, before: Int, count: Int) {} | |||
| override fun afterTextChanged(s: Editable) { | |||
| PreferenceManager.getDefaultSharedPreferences(this@MainActivity) | |||
| .edit().putString(KEY_PASSPORT_NUMBER, s.toString()).apply() | |||
| .edit().putString(KEY_PASSPORT_NUMBER, s.toString().uppercase()).apply() | |||
There was a problem hiding this comment.
I think if we want to do this, we should probably do it in the UI level, so people can see what is being entered.
There was a problem hiding this comment.
Ok, I've pushed a new change now when you get a chance.
GlennReilly
force-pushed
the
fix_error_scenario_if_user_enters_lowercase_letters_in_passport_number
branch
2 times, most recently
from
08fc8ca to
d6841ae
Compare
tananaev
reviewed
Sep 13, 2024
| @@ -73,6 +73,7 @@ import java.text.ParseException | |||
| import java.text.SimpleDateFormat | |||
| import java.util.* | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Sure, have done so now @tananaev
tananaev
reviewed
Sep 13, 2024
| @@ -57,6 +57,7 @@ | |||
| android:id="@+id/input_passport_number" | |||
| android:layout_width="match_parent" | |||
| android:layout_height="wrap_content" | |||
| android:inputType="textCapCharacters" | |||
GlennReilly
force-pushed
the
fix_error_scenario_if_user_enters_lowercase_letters_in_passport_number
branch
from
d6841ae to
1865ebf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Anton, I found I was getting an error
org.jmrtd.CardServiceProtocolException: BAC failed in MUTUAL AUTH (SW = 0x6700: WRONG LENGTH) (step: 2)if I entered my passport aspa1234567instead ofPA1234567, so thought you might consider this quick fix for it.Regards,
Glenn