Refact: Apply strict mode #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify type errors that occur when the strict is set to true
|
I see couple of issues with more types locally. Will sort them out as well as the tests. I will push on top of your fork then merge them all together, if you don't mind. |
|
Of course, that's fine. Thank you for your positive review |
tamimaj
reviewed
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correction of type error that occurs when the strict of tsconfig is set to true.
If you do the test with the strict true, the test code is not modified, so an error occurs. I would appreciate it if you could correct it properly.
I've annotated the strict after I've finished the work.
ref: #15