Allow to parse of elements of multiple types #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed step for distinguish elements of multiple types on the user side (when calling "for xml := range parser.Stream()").
When creating XMLParser user could specify list of multiple names to parse. Elements returned from parser.Stream() now embeds Name to distinguish them.
setnicka
changed the title
|
This look clean and useful. Tests are passing right? Some basic tests for this feature would be good. |
|
I added tests for multiple tags parsing even with when they are nested (I expect only not nested occurrences should be returned). All tests are passing. |
|
Now merged and tagged with version v1.2.0. Thanks for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there are multiple types of elements in the XML file (for example OSM export - it contains nodes, ways and relations) but for parsing this the three loops through the whole file were needed.
These changes allows to specify multiple elements to parse. It should be backward compatible for any normal usage of the xml-stream-parser because there are only added item into
XMLElementstruct and changedstringargument to...string.