Add a function to get the value of a field by path and indexation. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Eloy, This is cool thanks for adding. First impressions, Why no function receiver, maybe receiver of XMLElement and remove the first parameter from function? and instead GetField name how about GetValue isn't it more informative? Tamer |
|
Hi @tamerh here you have ;) |
|
Great. Just better with pointer receiver? And i guess both "else" are not needed as golint gives me warning? |
|
ok!! Done :) |
|
Merged:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a function to get the value of a field by path and indexation.