Added ability to center output with a flag. #26
Conversation
| rand = "0.8.5" | ||
| rust-embed = { version = "8.5.0" } | ||
| showie = "1.0.1" | ||
| termion = "4.0.5" |
There was a problem hiding this comment.
Termion is a pretty big crate just to use one function, are you sure it isn't possible to just re-implement a simple terminal size function? I haven't looked into it myself, but I assume it isn't too bad.
There was a problem hiding this comment.
I'll take a look. I think there's also a package called terminal-size. This was originally a quick and dirty hack I put together for personal use, so I freely admit that the code could probably be better. I'll look into it!
There was a problem hiding this comment.
Would switching to terminal_size be adequate? It's much smaller.
| eprintln!("{}", names.join(", ")); | ||
| let output = &names.join(", "); | ||
| if args.center { | ||
| let (width, _) = termion::terminal_size().expect("Must be run in terminal"); |
There was a problem hiding this comment.
You're getting width twice, for not much reason. I'd say maybe split off a function to get padding, and pass in a terminal width as well as a content width. The code would be a lot cleaner that way.
| let image = showie::to_ascii(&combined); | ||
| if args.center { | ||
| let (width, _) = termion::terminal_size().expect("Must be run in terminal"); | ||
| for line in image.lines() { |
There was a problem hiding this comment.
Here, this assumes that each line will be a different length for some reason. You don't need to compute the line padding every single line, just do it once and then apply it to each line.
Added the ability to center the output with a simple
--centerflag. This meant I added a few dependencies, specifically termion and ansi-width, to assist.