Skip to content

Commit

Permalink
Temporarily remove ESLint rule that breaks plugin's linting in VSCode (
Browse files Browse the repository at this point in the history
…software-mansion#4720)

## Summary

With changes from software-mansion#4672 developing plugin is difficult because VSCode
has problem resolving correct `tsconfig` and linting doesn't work in the
editor (but it works in the CLI at least). This PR removes this rule
till proper solution is found.


![image](https://github.com/software-mansion/react-native-reanimated/assets/40713406/311dfdeb-637d-49cd-808d-75d151cb75c8)
  • Loading branch information
tjzel authored Jul 12, 2023
1 parent 7382019 commit f188871
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 9 deletions.
5 changes: 1 addition & 4 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
module.exports = {
root: true,
parser: '@typescript-eslint/parser',
parserOptions: {
project: './tsconfig.json',
},
extends: [
'standard',
'plugin:@typescript-eslint/recommended',
Expand Down Expand Up @@ -37,7 +34,7 @@ module.exports = {
],
'@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
'@typescript-eslint/no-var-requires': 'warn',
'@typescript-eslint/no-duplicate-type-constituents': 'error',
// '@typescript-eslint/no-duplicate-type-constituents': 'error', // TODO this currently breaks ESLint for VSCode in plugin
eqeqeq: 'error',
'no-unreachable': 'error',
},
Expand Down
3 changes: 0 additions & 3 deletions plugin/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
module.exports = {
root: true,
extends: '../.eslintrc.js',
parserOptions: {
project: './tsconfig.json',
},
rules: {
'curly': 'error',
},
Expand Down
3 changes: 1 addition & 2 deletions plugin/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,5 @@
"declaration": true,
"declarationDir": "types"
},
"files": ["src/plugin.ts"],
"include":["src/**/*"]
"include": ["src/**/*"]
}

0 comments on commit f188871

Please sign in to comment.