This repository was archived by the owner on May 25, 2022. It is now read-only.
API Update and Bug Fixes #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All APIs updated to latest versions. Fixed bug where not all users were found if the server was too large.
taliyos
commented
Sep 7, 2019
| private CommandHandler _handler; | ||
|
|
||
| private const string Version = "0.3.0a2"; | ||
| private const string Version = "0.3.0a3"; |
There was a problem hiding this comment.
Incrementing version for version control
taliyos
commented
Sep 7, 2019
| await _client.StartAsync(); | ||
| _handler = new CommandHandler(); | ||
| await _handler.InitializeAsync(_client); | ||
| while (_client.ConnectionState != ConnectionState.Connected) { } |
There was a problem hiding this comment.
Replaces Task.Delay(), making the program update roles once the bot connects to the server.
taliyos
commented
Sep 7, 2019
| { | ||
| Console.WriteLine("---------------------------------------------------------------------"); | ||
| Console.WriteLine("Check the GitHub repository (https://github.com/talios0/Form2RoleBot/releases) for help. If a bug is encontered, submit an issue on the repo."); | ||
| Console.WriteLine("Check the GitHub repository (https://github.com/talios0/Form2RoleBot) for help. If a bug is encontered, submit an issue on the repo."); |
There was a problem hiding this comment.
Removed /releases since help is on the README
taliyos
commented
Sep 7, 2019
| // [assembly: AssemblyVersion("1.0.*")] | ||
| [assembly: AssemblyVersion("1.0.0.0")] | ||
| [assembly: AssemblyFileVersion("0.1.1.0")] | ||
| [assembly: AssemblyFileVersion("0.3.0.3")] |
There was a problem hiding this comment.
Changed version number to match
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All APIs updated to latest versions.
Fixed bug where not all users were found if the server was too large.