-
Notifications
You must be signed in to change notification settings - Fork 23
Add FixedBuilderScore contract and deployment script #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| nodejs 20.12.2 | ||
| solidity 0.8.24 | ||
| yarn 1.22.19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // SPDX-License-Identifier: MIT | ||
| pragma solidity ^0.8.24; | ||
|
|
||
| import "@openzeppelin/contracts/access/Ownable.sol"; | ||
|
|
||
| /// @title Fixed Builder Score | ||
| /// @notice A dummy PassportBuilderScore that returns a fixed score for all users | ||
| contract FixedBuilderScore is Ownable { | ||
| uint256 public fixedScore; | ||
|
|
||
| event FixedScoreUpdated(uint256 oldScore, uint256 newScore); | ||
|
|
||
| constructor(uint256 _fixedScore, address _owner) Ownable(_owner) { | ||
| fixedScore = _fixedScore; | ||
| } | ||
|
|
||
| /// @notice Set the fixed score returned for all passport IDs | ||
| /// @param _fixedScore The new fixed score | ||
| function setFixedScore(uint256 _fixedScore) external onlyOwner { | ||
| uint256 oldScore = fixedScore; | ||
| fixedScore = _fixedScore; | ||
| emit FixedScoreUpdated(oldScore, _fixedScore); | ||
| } | ||
|
|
||
| /// @notice Returns the fixed score for any passport ID | ||
| /// @param _passportId Ignored - returns the same score for all | ||
| /// @return The fixed score | ||
| function getScore(uint256 _passportId) external view returns (uint256) { | ||
| return fixedScore; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| import { ethers, network } from "hardhat"; | ||
|
|
||
| const TALENT_VAULT_MAINNET = "0x23Ff3256A29847d7EF760943bd6679b565CbdE5a"; | ||
|
|
||
| // Set to 60 to give everyone the bonus yield rate, or 0 for base rate only | ||
| const INITIAL_FIXED_SCORE = 60; | ||
|
|
||
| async function main() { | ||
| const isMainnet = network.name === "mainnet" || network.name === "base"; | ||
|
|
||
| if (!isMainnet) { | ||
| return; | ||
| } | ||
|
|
||
| const talentVaultAddress = TALENT_VAULT_MAINNET; | ||
|
|
||
| console.log(`Deploying Fixed Builder Score at ${network.name}`); | ||
|
|
||
| const [admin] = await ethers.getSigners(); | ||
|
|
||
| console.log(`Admin/Owner will be ${admin.address}`); | ||
|
|
||
| // Deploy FixedBuilderScore | ||
| const fixedBuilderScoreContract = await ethers.getContractFactory("FixedBuilderScore"); | ||
| const fixedBuilderScore = await fixedBuilderScoreContract.deploy(INITIAL_FIXED_SCORE, admin.address); | ||
| await fixedBuilderScore.deployed(); | ||
|
|
||
| console.log(`Fixed Builder Score deployed at ${fixedBuilderScore.address}`); | ||
| console.log(`Initial fixed score: ${INITIAL_FIXED_SCORE}`); | ||
| console.log(`Owner: ${admin.address}`); | ||
|
|
||
| // Update TalentVault to use the new FixedBuilderScore | ||
| console.log(`\nUpdating TalentVault at ${talentVaultAddress}...`); | ||
| const talentVault = await ethers.getContractAt("TalentVault", talentVaultAddress); | ||
| const tx = await talentVault.setPassportBuilderScore(fixedBuilderScore.address); | ||
| await tx.wait(); | ||
|
|
||
| console.log(`TalentVault.setPassportBuilderScore updated to ${fixedBuilderScore.address}`); | ||
|
|
||
| console.log("\n--- Verification Command ---"); | ||
| console.log( | ||
| `npx hardhat verify --network ${network.name} ${fixedBuilderScore.address} ${INITIAL_FIXED_SCORE} ${admin.address}` | ||
| ); | ||
|
|
||
| console.log("\nDone"); | ||
| } | ||
|
|
||
| main() | ||
| .then(() => process.exit(0)) | ||
| .catch((error) => { | ||
| console.error(error); | ||
| process.exit(1); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing await on async ensureTimestamp calls
Medium Severity
The
ensureTimestampfunction returns aPromiseand needs to be awaited. Withoutawait, the EVM timestamp may not be set before the subsequentrefresh()call executes, causing the test to calculate rewards over an incorrect time period. Other usages inTalentRewardClaim.tsand theensureTimeIsAfterLockPeriodhelper function correctly useawait.Additional Locations (1)
test/contracts/talent/TalentVault.ts#L1038-L1039