Merged
Conversation
Owner
|
Is |
Contributor
Author
|
displayName is a field that probably arrives from google authentication, I installed headplane with google oauth and I can't see the name in the UI, I found that the name was in displayName |
Owner
|
Does this break on non google OIDC setups? |
Contributor
Author
|
It only adds displayName as fallback, so it won't break anything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using google OAuth names were not beeing displayed, and list of user were list of empty elements, also owners of machines were not viewable... I added more fallback display action and also added (displayName) as the name of the user when it is not available.