Skip to content

Commit

Permalink
bigtable: update readme examples (googleapis#1538)
Browse files Browse the repository at this point in the history
  • Loading branch information
callmehiphop authored and stephenplusplus committed Aug 29, 2016
1 parent c8bc277 commit b9e4a32
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 11 deletions.
2 changes: 0 additions & 2 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ To run the system tests, first create and configure a project in the Google Deve
- **GCLOUD_TESTS_KEY**: The path to the JSON key file.
- ***GCLOUD_TESTS_API_KEY*** (*optional*): An API key that can be used to test the Translate API.
- ***GCLOUD_TESTS_DNS_DOMAIN*** (*optional*): A domain you own managed by Google Cloud DNS (expected format: `'gcloud-node.com.'`).
- ***GCLOUD_TESTS_BIGTABLE_ZONE*** (*optional*): A zone containing a Google Cloud Bigtable cluster.
- ***GCLOUD_TESTS_BIGTABLE_CLUSTER*** (*optional*): A cluster used to create Bigtable Tables on.

Install the [gcloud command-line tool][gcloudcli] to your machine and use it to create the indexes used in the datastore system tests with indexes found in `system-test/data/index/yaml`:

Expand Down
7 changes: 3 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -213,12 +213,11 @@ var bigtable = require('@google-cloud/bigtable');

var bigtableClient = bigtable({
projectId: 'grape-spaceship-123',
keyFilename: '/path/to/keyfile.json',
zone: 'my-zone',
cluster: 'my-cluster'
keyFilename: '/path/to/keyfile.json'
});

var table = bigtableClient.table('prezzy');
var instance = bigtableClient.instance('my-instance');
var table = instance.table('prezzy');

table.getRows(function(err, rows) {});

Expand Down
9 changes: 4 additions & 5 deletions packages/bigtable/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,11 @@ $ npm install --save @google-cloud/bigtable
```js
var bigtable = require('@google-cloud/bigtable')({
projectId: 'grape-spaceship-123',
keyFilename: '/path/to/keyfile.json',
zone: 'my-zone',
cluster: 'my-cluster'
keyFilename: '/path/to/keyfile.json'
});

var table = bigtable.table('prezzy');
var instance = bigtable.instance('my-instance');
var table = instance.table('prezzy');

table.getRows(function(err, rows) {});

Expand Down Expand Up @@ -106,4 +105,4 @@ var bigtable = require('@google-cloud/bigtable')({
[dev-console]: https://console.developers.google.com/project
[gcloud-bigtable-docs]: https://googlecloudplatform.github.io/google-cloud-node/#/docs/bigtable
[cloud-bigtable-docs]: https://cloud.google.com/bigtable/docs
[cloud-bigtable-cluster]: https://cloud.google.com/bigtable/docs/creating-compute-instance
[cloud-bigtable-cluster]: https://cloud.google.com/bigtable/docs/creating-compute-instance

0 comments on commit b9e4a32

Please sign in to comment.