Allow caller to supply their own session object. #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a constructor to the Peri() object that takes a `session` parameter. If supplied, this session object will be used instead of creating a new one. My use case is for HTTP proxy support, but presumably the caller could change the user agent in some other way if they wanted to. If no session param is supplied, one is created, as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sessionparameter. If supplied, this session object will be used instead of
creating a new one. My use case is for HTTP proxy support, but
presumably the caller could change the user agent in some other way if
they wanted to. If no session param is supplied, one is created, as
before.
This PR also includes a fix to the username parsing bug from @gavvvr -- I should have probably kept that separate. I can back it out and re-submit if necessary.