Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.3.1 #9

Merged
merged 8 commits into from
May 13, 2020
Merged

Release 1.3.1 #9

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f7371aa
fix: mixin 没有 return type
taixw2 May 7, 2020
6fcb57c
fix: collect ts error
taixw2 May 8, 2020
0bad38b
refactor: 删除文档, 独立仓库
taixw2 May 9, 2020
622a80a
feat: action type 的 Symbol 基于方法名
taixw2 May 12, 2020
a290055
feat(release): release v1.3.1
taixw2 May 12, 2020
8b5b376
chore: 更新 release 脚本
taixw2 May 12, 2020
0632070
chore: 删除依赖
taixw2 May 13, 2020
d2675b6
chore: 修改 README
taixw2 May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: action type 的 Symbol 基于方法名
  • Loading branch information
@taixw2
taixw2 committed May 12, 2020
commit 622a80acaae6cf7476568aac3cec4389bddd1be3
34 changes: 16 additions & 18 deletions packages/common/src/helper/effect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,23 @@ import { TAKE_EVERY, EFFECT_METHODS_META, SymbolType, EFFECT_HELPERS, EFFECT_MET
import { EffectTypeInterface } from '@dxjs/shared/interfaces/dx-effect-type.interface';

export function Effect(actionTypeArg?: SymbolType, helperTypeArg?: any, ...args: any[]): MethodDecorator {
/**
* 参数替换：
* @Effect()
* @Effect(TakeEvery)
* @Effect("actionType", TakeEvery)
* @Effect(Throttle, 350)
* @Effect("actionType", Throttle, 350)
*/
const _defaultActionType = Symbol('__action_type');
let _actionType = actionTypeArg ?? _defaultActionType;
let _helperType = helperTypeArg ?? TAKE_EVERY;

if (EFFECT_HELPERS.includes(actionTypeArg!)) {
if (helperTypeArg) args.unshift(helperTypeArg);
[_actionType, _helperType] = [_defaultActionType, actionTypeArg!];
}

return (target: any, key: SymbolType, descriptor: TypedPropertyDescriptor<any>): TypedPropertyDescriptor<any> => {
// eslint-disable-next-line prettier/prettier
/**
* 参数替换：
* @Effect()
* @Effect(TakeEvery)
* @Effect("actionType", TakeEvery)
* @Effect(Throttle, 350)
* @Effect("actionType", Throttle, 350)
*/
const _defaultActionType = Symbol(String(key));
let _actionType = actionTypeArg ?? _defaultActionType;
let _helperType = helperTypeArg ?? TAKE_EVERY;

if (EFFECT_HELPERS.includes(actionTypeArg!)) {
if (helperTypeArg) args.unshift(helperTypeArg);
[_actionType, _helperType] = [_defaultActionType, actionTypeArg!];
}

const effectKeys: Set<SymbolType> = Reflect.getMetadata(EFFECT_METHODS_KEY, target.constructor) ?? new Set();
if (effectKeys.has(key)) return descriptor;
Expand Down