Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lodash #5390

Merged
merged 10 commits into from
Sep 6, 2021
Merged

Remove lodash #5390

merged 10 commits into from
Sep 6, 2021

Conversation

RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented Sep 4, 2021

This PR will get rid of the lodash dependency since it is rather big. I replaced most of the functions with plain built-ins. I've added a few extra utilities to mimic lodash' behaviour.
Some files (like the resolveConfig) can use some refactoring, however I tried to mainly focus on lodash's removal.

@RobinMalfait RobinMalfait changed the title remove lodash [WIP] Remove lodash Sep 4, 2021
@RobinMalfait RobinMalfait force-pushed the remove-lodash-dependency branch from 9403471 to 14fcdcd Compare September 6, 2021 11:21
@RobinMalfait RobinMalfait force-pushed the remove-lodash-dependency branch from 14fcdcd to ff3e8f6 Compare September 6, 2021 11:26
@RobinMalfait RobinMalfait changed the title [WIP] Remove lodash Remove lodash Sep 6, 2021
Copy link
Contributor

@TrySound TrySound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@adamwathan adamwathan merged commit a34bd62 into master Sep 6, 2021
@adamwathan adamwathan deleted the remove-lodash-dependency branch September 6, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants