Add variant prefix to last class in a selector, not the first #497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #464.
Prior to this PR, responsive variants naively added the screen prefix right at the beginning of a selector, so:
...would become:
As pointed out in #464, it's much more intuitive to expect this:
This PR fixes this issue by always adding prefixes to the last class in a selector. There is a chance that in the future we discover this is not preferable for some variant idea we haven't thought of yet, but right now this feels right and is a simple-ish change.
In the future (once we add the ability to register custom variants through plugins), we intend to defer control of how responsive prefixes are applied to the variant plugin itself, so it's all gonna be fine.