Resolve purge paths #4214
Merged
Resolve purge paths #4214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4214 +/- ##
==========================================
+ Coverage 71.17% 71.67% +0.49%
==========================================
Files 218 220 +2
Lines 4721 4730 +9
Branches 776 780 +4
==========================================
+ Hits 3360 3390 +30
+ Misses 1274 1260 -14
+ Partials 87 80 -7
Continue to review full report at Codecov.
|
fixes tests hanging
|
Thank you sir! |
adamwathan
pushed a commit
that referenced
this pull request
May 7, 2021
* resolve purge paths * add test for purgecss pattern resolution * resolve purgecss patterns relative to the config file if there is one * account for raw content when transforming purgecss options * append test name to postcss `from` option in purge tests fixes tests hanging * add test for relative purge path resolution in JIT mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3948
This PR resolves purge paths relative to the config file when there is one, or the current working directory when there isn't. This avoids running into a
fast-globbug, but also is just generally sensible I think, as we want the paths to be relative to the config file, and not the current working directory.