Add missing colors in defaultConfig.stub.js #2639
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! This is actually by design, we are only enabling a few key colors by default and including the rest in colors.js for people to choose from if they need them. Colors increase the file size dramatically so we don't want to provide more than makes sense by default. |
Closed
|
But isn't the unused colors removed in the production build when treeshaking is performed? |
|
Yep but still no reason to have 5 different types of gray to choose from and the bigger the unpurged CSS gets the worse browser performance gets in development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added all missing colors, imported from colors.js.