Skip to content

Add self-baseline-last #17476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Conversation

philipp-spiess
Copy link
Member

@philipp-spiess philipp-spiess commented Apr 1, 2025

This PR also adds a new self-baseline-last utility similar to items-baseline-last added previously. We've also discussed adding a content-baseline-last utility but since the browser support for this is very limited and we weren't able to get this to do anything even in the supported browsers, we decided against it.

Test plan

Updated the utility tests.

@philipp-spiess philipp-spiess force-pushed the feat/self-content-baseline-last branch 2 times, most recently from 86ace9e to b5ee032 Compare April 1, 2025 11:30
@philipp-spiess philipp-spiess changed the title Add self-baseline-last and content-baseline-last Add self-baseline-last Apr 1, 2025
@philipp-spiess philipp-spiess marked this pull request as ready for review April 1, 2025 11:32
@philipp-spiess philipp-spiess requested a review from a team as a code owner April 1, 2025 11:32
@philipp-spiess philipp-spiess force-pushed the feat/self-content-baseline-last branch from b5ee032 to 466e4ad Compare April 1, 2025 11:32
@philipp-spiess philipp-spiess enabled auto-merge (squash) April 1, 2025 11:34
@philipp-spiess philipp-spiess merged commit 55d7a65 into main Apr 1, 2025
7 checks passed
@philipp-spiess philipp-spiess deleted the feat/self-content-baseline-last branch April 1, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants