Rename --width-* namespace to --container-*
#14898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
approved these changes
Nov 6, 2024
| @@ -135,6 +135,7 @@ export function keyPathToCssProperty(path: string[]) { | |||
| if (path[0] === 'animation') path[0] = 'animate' | |||
| if (path[0] === 'transitionTimingFunction') path[0] = 'ease' | |||
| if (path[0] === 'fontFamily') path[0] = 'font' | |||
| if (path[0] === 'maxWidth') path[0] = 'container' | |||
There was a problem hiding this comment.
Should this be just width? --max-width is still a namespace that is valid when used with the max-width helper but I think the intention is that the width namespace migrates to container by default?
There was a problem hiding this comment.
Oh I see in v3 the max-w-* w-* and min-* utilities don't share a dimension :D never mind me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames all of the
--width-*variables to--container-*to better communicate the purpose of these tokens as layout container sizes. These are the values that were historically stored undermaxWidthin the v3 and earlier eras, and were also re-used by the container queries plugin.The name
--container-*feels like a better match alongside the--breakpoint-*namespace and since these both serve that same sort of purpose it makes sense to me that the name should be optimized for feeling "right" in that context.I like that this also sort of advertises Tailwind's support for container queries directly in the CSS variables themselves, and helps people understand what these are really intended to be used for.