Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rebuilds when editing imported CSS files #14561

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

RobinMalfait
Copy link
Member

This PR fixes an issue where importing other CSS files, then changing those CSS files didn't trigger a rebuild. This PR fixes that by making sure that the imported CSS files are properly watched.

This PR also adds some integration tests for @tailwindcss/postcss, @tailwindcss/vite and @tailwindcss/cli to make sure this works as expected.

Copy link
Member

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice re. test upgrades

packages/@tailwindcss-node/src/compile.ts Show resolved Hide resolved
These tests make sure that changing an imported stylesheet results in a
full rebuild by overriding some `@theme` values.
@RobinMalfait RobinMalfait force-pushed the fix/watch-imported-css-files branch from f66a4b4 to 590304e Compare October 1, 2024 11:45
@RobinMalfait RobinMalfait enabled auto-merge (squash) October 1, 2024 11:46
@RobinMalfait RobinMalfait merged commit 30fbc2c into next Oct 1, 2024
1 check passed
@RobinMalfait RobinMalfait deleted the fix/watch-imported-css-files branch October 1, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants