Don’t throw when client is missing the textDocument capability
#1252
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm gonna skip the automated tests for now. I can't find anything reasonable in the language server spec about how things should act in this case so I'm just gonna wait for people to open an issue if that ever happens. |
RobinMalfait
approved these changes
Mar 12, 2025
philipp-spiess
approved these changes
Mar 12, 2025
thecrypticace
force-pushed
the
fix/no-throw-missing-textdocument-capability
branch
from
cb105ae to
7798c1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1251
This needs more research before merging because we probably need to skip registration of providers. And possibly not even attempt to initialize projects in this case? Not entirely sure.