Fix loading of the Yarn PnP API #1151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
fix/yarn-pnp-resolver-windows
branch
3 times, most recently
from
b9ee81d to
a252016
Compare
thecrypticace
changed the title
A call to `setup()` is required for resolution to function at all
It does not intercept calls to `await import()`. Manually registering the ESM hook also results in failed fs.stat calls.
thecrypticace
force-pushed
the
fix/yarn-pnp-resolver-windows
branch
from
caf7b35 to
8e70c66
Compare
philipp-spiess
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1149
This PR does a few things:
require(…)because that's what's hooked at runtime. It does not work withawait import(…)unfortunately. I plan to investigate this more to see if I can change this back in the future. We really should not ever load the CJS version of v4.There are most certainly some other problems using Yarn PnP with older Tailwind CSS versions and IntelliSense right now but I plan to address these in a followup PR later.
Here's the output panel from a project loaded through Yarn PnP on Windows:
