Fix compatible plugin chaining when prettier-vscode passes plugin.name as an absolute path on Windows.#459
Open
ramong26 wants to merge 1 commit into
Conversation
…e as an absolute path on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolved a plugin chaining compatibility issue between:
@ianvs/prettier-plugin-sort-importsprettier-plugin-tailwindcssThe issue started occurring on
prettier-plugin-tailwindcss >= 0.7.3.Problem
In a Windows + pnpm + prettier-vscode environment, the following symptoms were observed:
Depending on plugin order, only one feature worked:
VSCode format-on-save and CLI formatting produced different results
prettier-plugin-tailwindcss@0.7.2worked correctly, while0.7.3+introduced the issueRelated issues:
Root Cause
prettier-plugin-tailwindcssinternally checks enabled plugins using plugin names.However, in prettier-vscode on Windows, plugin names are resolved as native file paths:
while compatibility checks expect slash-based package names:
Because Windows paths use backslashes (
\), plugin chaining silently failed.Fix
Normalized plugin names before passing them into the parser chain.
Result
Both features now work correctly together:
Verified in:
prettier --write)