Add support for @plugin and @config in v4
#316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think relying on I think this PR is a good improvement on its own already, so let's just get this merged and released and add TypeScript support later. |
RobinMalfait
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just realized we forgot to add a
loadConfigstub when we releasedv4.0.0-alpha.21. We also need to actually fill in the implementations of loadPlugin and loadConfig so this PR does that.We still need to add typescript support which I think means either:
@tailwindcss/nodein the prettier plugin; ORI'm not actually sure which option we should go with so I've not added typescript support yet.