Mark Vue and React packages as side-effect free #929
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently adding an
exports
field implicitly marks a package as having side-effects in some cases even when direct imports of a file didn't previously do so.Rollup and esbuild seem to not care about this when dealing with files directly. But Vite's internal node resolution logic does. I'm guessing Remix might be in a similar situation here. We export pure render functions for both React and Vue so marking our packages with
"sideEffects": false
should be fine.Fixes #926