Ensure data-open on ComboboxInput is up to date
#3791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
RobinMalfait
force-pushed
the
fix/issue-3718
branch
from
be16709 to
ede6296
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
data-openstate on theComboboxInputwasn't always up to date. You can see this behavior if you use theimmediateprop, focus into theComboboxInput, then pressEscapeto close the combobox. Thedata-openstate would still be present.This was just a silly internal bug where the
useMemodependencies were not correctly set up. Simplified the internaluseMemohook and made sure all the dependencies are available.Fixes: #3718